[Bug 619332] Review Request: perl-MooseX-Types-VariantTable - Type constraint based variant table

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619332

Marcela Mašláňová <mmaslano at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mmaslano at redhat.com
               Flag|                            |fedora-review+

--- Comment #1 from Marcela Mašláňová <mmaslano at redhat.com> 2010-08-03 09:22:55 EDT ---
- rpmlint checks return:
rpmlint perl-MooseX-Types-VariantTable-0.04-1.fc14.src.rpm 
perl-MooseX-Types-VariantTable.src: W: no-cleaning-of-buildroot %clean
perl-MooseX-Types-VariantTable.src: W: no-buildroot-tag
perl-MooseX-Types-VariantTable.src: W: no-%clean-section
These are now needed only for EPEL.

- package meets naming guidelines OK
- package meets packaging guidelines OK
- license (GPL+ or Artistic) OK, text in %doc, matches source OK
- spec file legible, in am. english OK
- source matches upstream OK ec6022745e805619e2a322d6db1bca71
- package compiles on devel (x86) OK
- no missing BR OK
- no unnecessary BR OK
- no locales OK
- not relocatable OK
- owns all directories that it creates OK
- no duplicate files OK
- permissions ok OK
- macro use consistent OK
- code, not content OK
- no need for -docs OK
- nothing in %doc affects runtime OK
- no need for .desktop file OK

ACCEPT

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.