Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590244
Andrea Musuruane <musuruan at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #28 from Andrea Musuruane <musuruan at gmail.com> 2010-12-08 11:59:24 EST ---
Package Review
==============
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines. [1]
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Spec file is legible and written in American English.
[x] Spec file lacks Packager, Vendor, PreReq tags.
[x] Spec uses macros instead of hard-coded directory names.
[!] Package consistently uses macros.
[x] Macros in Summary, %description expandable at SRPM build time.
[x] PreReq is not used.
[x] Requires correct, justified where necessary.
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines. [2]
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)).
[x] Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the beginning of
%install.
[-] Package use %makeinstall only when ``make install DESTDIR=...'' doesn't
work.
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x] The spec file handles locales properly.
[x] Changelog in prescribed format.
[x] Rpmlint output is silent.
$ rpmlint /home/andrea/rpmbuild/SRPMS/pinta-0.5-3.fc14.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint /home/andrea/rpmbuild/RPMS/x86_64/pinta-0.5-3.fc14.x86_64.rpm
pinta.x86_64: E: no-binary
pinta.x86_64: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 1 errors, 1 warnings.
These are fine, as defined by the mono packaging guidelines.
[x] License field in the package spec file matches the actual license.
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[-] License file installed when any subpackage combination is installed.
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[3,4]
[x] Sources contain only permissible code or content.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package : e7bbee973f9dcf86b4c9a5a232f513f9
MD5SUM upstream package : e7bbee973f9dcf86b4c9a5a232f513f9
[-] Compiler flags are appropriate.
[-] %build honors applicable compiler flags or justifies otherwise.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package does not own files or directories owned by other packages.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[!] Permissions on files are set properly.
[x] Each %files section contains %defattr.
[x] No %config files under /usr.
[-] %config files are marked noreplace or the reason is justified.
[x] Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application. [5]
[x] Package contains a valid .desktop file.
[x] Package contains code, or permissible content.
[-] Package contains a SysV-style init script if in need of one.
[x] File names are valid UTF-8.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[x] Package contains no bundled libraries.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -static subpackage, if present.
[x] Package contains no static executables.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[x] Useful -debuginfo package or justification otherwise.
[x] Rpath absent or only used for internal libs.
[x] Package does not generate any conflict.
[x] Package does not contains kernel modules.
[x] Package is not relocatable.
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
F14/x86_64
[x] Package is not known to require ExcludeArch.
"ExcludeArch: sparc64" is fine. Mono is available only for sparc32.
[x] Package installs properly.
[x] Package obeys FHS, except libexecdir and /usr/target.
[!] Package meets the Packaging Guidelines. [6]
=== SUGGESTED ITEMS ===
[x] Package functions as described.
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] SourceX is a working URL.
[x] SourceX / PatchY prefixed with %{name}.
[x] Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[-] %check is present and all tests pass.
[-] Usually, subpackages other than devel should require the base package
using a fully versioned dependency.
[?] Reviewer should test that the package builds in mock.
[-] Package should compile and build into binary rpms on all supported
architectures.
[x] Dist tag is present.
[!] Spec use %global instead of %define.
[x] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files are correct.
[x] No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[!] Packages should try to preserve timestamps of original installed files.
[-] File based requires are sane.
[!] Man pages included for all executables.
[x] Uses parallel make.
[-] Patches link to upstream bugs/comments/lists or are otherwise justified.
=== Issues ===
1. Please do not reference Paint.NET in the description:
http://fedoraproject.org/wiki/Packaging/Guidelines#Trademarks_in_Summary_or_Description
2. Macros are not used consistently. You used %{__sed} and make (not
%{__make}). Just use the short form. Command macros are more readable in this
way.
3. chmod -x pinta.1 in %prep and not pinta.1.gz in %install
4. Use %global instead of %define.
http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
5. When adding file copying commands in the spec file, consider using a command
that preserves the files' timestamps, eg. cp -p or install -p.
http://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
Items 1 to 4 are mandatory, otherwise the package is in quite good shape. Good
work!
[1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines
[2] https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
[3] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines
[4] https://fedoraproject.org/wiki/Licensing:Main
[5] https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
[6] https://fedoraproject.org/wiki/Packaging:Guidelines
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.