[Bug 661154] Review Request: votca-csg - VOTCA coarse graining engine

bugzilla at redhat.com bugzilla at redhat.com
Tue Dec 14 10:58:37 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661154

Dominik 'Rathann' Mierzejewski <rpm at greysector.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |rpm at greysector.net
               Flag|                            |fedora-review?

--- Comment #5 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net> 2010-12-14 05:58:36 EST ---
Source matches upstream:

$ md5sum votca-csg-1.0.1.tar.gz*
855fec6510665d45d81c4987f62b95b2  votca-csg-1.0.1.tar.gz
855fec6510665d45d81c4987f62b95b2  votca-csg-1.0.1.tar.gz.1

Comments:

1. Typo:
%package devel
...
Requires:       votka-tools-devel

./share/template/template.cc is missing licencing information

2. Timestamps are not preserved in make install.

Otherwise the package looks fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list