[Bug 664619] Review Request: jspeex - Java Implementation of Speex

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664619

--- Comment #3 from Stanislav Ochotnicky <sochotni at redhat.com> 2010-12-21 09:32:24 EST ---
(In reply to comment #2)
> (In reply to comment #1)
> > Few notes from just a quick look:
> >  * BuildRoot is not needed (ignore rpmlint warning)
> >  * rm -rf $RPM_BUILD_ROOT and %clean section not needed (see above)
> 
> - I think there is no harm in keeping that, in case we want to maintain a
> single spec across Fedora and EPEL

This is only needed on EL-5 and earlier. But yes, if you plan to support older
EPELs keep it in.

> >  * line "%doc %{_javadocdir}/%{name}/*" in %files should be removed (duplicate
> > entry)
> > 
> 
> - I believe the first entry is for directory ownership only, the second marks
> the files as doc ones.

yes, but it's still not needed. Instead of those two lines you can just have:
%doc %{_javadocdir}/%{name}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.