[Bug 559856] Review Request: libbsd - Library providing BSD-compatible functions for portability

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=559856

--- Comment #17 from Eric Smith <eric at brouhaha.com> 2010-02-06 22:55:29 EST ---
In reviews of other packages, I've been told that whether man pages should be
marked as %doc is a matter of taste.  However, I don't feel strongly about it
so I have removed the %doc per your request.

The requirement you marked as NEEDWORK, "MUST: All filenames in rpm packages
must be valid UTF-8", concerns the filename, not the content.  The filename in
question is a valid UTF-8 filename.  I don't like modifying the content of the
package, but it does seem harmless to "fix" the encoding of a man page, so I
have done so.

Thanks for the review!

Spec URL: http://fedorapeople.org/~brouhaha/libbsd/libbsd.spec
SRPM URL: http://fedorapeople.org/~brouhaha/libbsd/libbsd-0.2.0-3.fc12.src.rpm
Koji scratch build for f12-dist:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1967157

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.