[Bug 226476] Merge Review: talk

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226476

--- Comment #1 from Ondrej Vasik <ovasik at redhat.com> 2010-02-17 11:30:17 EST ---
Few things:
must:
dist tag missing
buildroot not acceptable (although not used by rpm, should be fixed)
%defattr(-,root,root,-) instead of %defattr(-,root,root)
Fix missing URL
Use versioned provides and obsoletes
Summary should not end with dot
talk.src:50: E: configure-without-libdir-spec -> consider %configure macro

should:
comment patches and source1,2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.