[Bug 537587] Review Request: dspam - bayesian filtering daemon, client, library and web ui

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537587

--- Comment #53 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-01-12 12:47:54 EST ---
For -0.18:

* disttag
  - Well, somehow I forgot to mention, however please consider
    to use %{?dist} (see below). This is useful when maintaining
    one software in multiple branches on Fedora:
    https://fedoraproject.org/wiki/Packaging/DistTag

* Owner/Group/Permission
  - Would you check the owner/group/permission of /var/run/dspam?
    I don't think setgid is needed for this directory and
    perhaps (0770,dspam,mail) is sufficient (however I don't know
    about dspam).

* sysvscript
-----------------------------------------------------
[root at localhost ~]# service dspam status ; echo $?
ServerPID missing in DSPAM configuration /etc/dspam.conf
1
-----------------------------------------------------
  - Well, any reason why ServerPID is not set by default
    (instead of setting this as "/var/run/dspam.pid" by default)?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.