[Bug 552831] Merge Review: perl-Date-Manip - A Perl module containing a wide variety of date manipulation routines

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=552831

--- Comment #1 from Jaroslav Škarvada <jskarvad at redhat.com> 2010-01-12 17:40:03 EST ---
MUST items:
[NO] rpmplint is silent:

$ rpmlint ./perl-Date-Manip.spec.
./perl-Date-Manip.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab:
line 13)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

[YES] Package meets naming and packaging guidelines.
Please see note (1).
[YES] Spec file matches base package name.
[YES] License file is present, matching with spec file, Licensing Guidelines
are met.
Please see note (2).
[YES] Spec file is legible and in American English.
[YES] Source match upstream.
[YES] Package builds OK.
[YES] BuildRequires is correct.
[YES] Package owns all the directories it creates.
[YES] Package has no duplicity in %files.
[YES] Permission on files are set properly.
[YES] %clean section is correct.
[YES] Spec file has consistent macro usage.
[YES] Package is code or permissible content.
[YES] %doc files don't affect runtime.
[YES] Package doesn't own files that other packages own.
[YES] Package has rm -rf RPM_BUILD_ROOT at beginning of %install.
[YES] All filenames are valid UTF-8.

Should items:
[YES] Should builds in mock.
[YES] Should have sane scriptlets.

Notes:
(1) Extra space in %description after the end of the first sentence.
(2) Can be LICENSE file included to %doc?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.