[Bug 553483] Review Request: dogtag-pki-console-ui - The Dogtag PKI Console User Interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=553483

--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> 2010-01-13 21:20:11 EST ---
(In reply to comment #2)
> Parag Nemade wrote:
> > Hi,
> >      I am not sure but I think all these dogtag*-ui packages should require some basic pki framework providing package, otherwise if someone just installs say dogtag-pki-console-ui package then he will just get some files installed from that package only. I think pki-common-ui should be Requires in all these -ui packages. Am I right? if so you need to add them to SPEC then.
> 
> Actually -- the intent of the UI packages was merely to separate brand-specific
> "text/graphics" from their associated non-UI component (much like a branding
> 'skin'):
> 
>     * 'pki-common' REQUIRES 'pki-common-ui' which is PROVIDED by EITHER
> 'dogtag-pki-common-ui' OR 'redhat-pki-common-ui'
>     * 'pki-ca' REQUIRES 'pki-ca-ui' which is PROVIDED by EITHER
> 'dogtag-pki-ca-ui' OR 'redhat-pki-ca-ui'
>     * 'pki-kra' REQUIRES 'pki-kra-ui' which is PROVIDED by EITHER
> 'dogtag-pki-kra-ui' OR 'redhat-pki-kra-ui'
>     * 'pki-ocsp' REQUIRES 'pki-ocsp-ui' which is PROVIDED by EITHER
> 'dogtag-pki-ocsp-ui' OR 'redhat-pki-ocsp-ui'
>     * 'pki-tks' REQUIRES 'pki-tks-ui' which is PROVIDED by EITHER
> 'dogtag-pki-tks-ui' OR 'redhat-pki-tks-ui'
>     * 'pki-ra' REQUIRES 'pki-ra-ui' which is PROVIDED by EITHER
> 'dogtag-pki-ra-ui' OR 'redhat-pki-ra-ui'
>     * 'pki-tps' REQUIRES 'pki-tps-ui' which is PROVIDED by EITHER
> 'dogtag-pki-tps-ui' OR 'redhat-pki-tps-ui'
>     * 'pki-console' REQUIRES 'pki-console-ui' which is PROVIDED by EITHER
> 'dogtag-pki-console-ui' OR 'redhat-pki-console-ui'
> 
> Additionally, the 'pki-common' component is ONLY REQUIRED by the Java/Tomcat
> packages 'pki-ca', 'pki-kra', 'pki-ocsp', 'pki-tks', and 'pki-console'; it is
> NOT REQUIRED by the Perl/Apache package 'pki-ra' NOR the C/C++/Apache package
> 'pki-tps'.

OK.


> 
> >      I tried to install all reviewed packages in Fedora but I see conflicts is not allowing me to install pki-common. May I know specific reason to have it conflicts with tomcat-native?I see both packages provides different files at different installation paths. As per https://fedoraproject.org/wiki/Packaging:Conflicts#Other_Uses_of_Conflicts: , we need to add some information in SPEC file. Sorry that I missed this in package review.
> 
> >      Can we have pki-common package updated with this conflict information in its spec file?
> 
> The Conflict problems associated with "tomcat-native" are detailed in
> https://bugzilla.redhat.com/show_bug.cgi?id=441974, and appeared to stem from
> attempting to run Tomcat using a different security model ( e. g. - openSSL
> (tomcat-native) conflicting with NSS (tomcatjss->JSS->NSS)).  Although I had
> originally suggested placing the "Conflicts:" keyword in the 'pki-common'
> package, I believe that it may be more appropriate to place it within the
> "tomcatjss" package?
> 
> Regardless of which package is chosen, are you suggesting that we need a
> clearer explanation regarding the reason for this conflict under the
> "%description" section?

Please document bug id and some information in pki-common SPEC file. And yes
you can also add in description that "this package conflicts with
tomcat-native"
Guidelines says "include the reasoning in a comment next to the Conflicts:
entry, so that it will be abundantly clear why it needed to exist."
Also, not sure whether we need to ask FESCo for approval of this Conflicts
usage though I see its correct reason to use it.

> 
> >      Please remove "Requires: bash" as it looks unnecessary.
> 
> We used "Requires: bash" because I believe that rpmbuild always needs at least
> one "Requires:", and we chose "Requires: bash" as the lone "Requires" statement
> in many of the UI- packages.  Is something else more appropriate (as this is
> what we ended up using in the "dogtag-pki-ui-ca" package)?
> 
 I suggested removing "Requires: bash" in pki-common review also. This is false
assumption that rpmbuild needs at least one "Requires". Please remove this from
all packages waiting for review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.