[Bug 553847] Review Request: pki-tks - The Dogtag Token Key Service
bugzilla at redhat.com
bugzilla at redhat.com
Tue Jan 19 08:45:16 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=553847
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> 2010-01-19 03:45:14 EST ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1931061
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
e08fa5c15a8c68bf4e2892c15f142f34f0f28158 pki-tks-1.3.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ Initscripts scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package pki-tks-1.3.0-4.fc13.noarch =>
Provides: mimehandler(application/vnd.mozilla.xul+xml)
mimehandler(application/xhtml+xml) mimehandler(text/html) mimehandler(text/mml)
mimehandler(text/xml)
Requires:java >= 1:1.6.0 pki-common pki-selinux pki-silent pki-tks-ui
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list