[Bug 556611] Review Request: ptpd - Precision Time Protocol daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556611

John W. Linville <linville at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(terjeros at phys.ntn
                   |                            |u.no)

--- Comment #5 from John W. Linville <linville at redhat.com> 2010-01-19 11:12:45 EST ---
There aren't restricted bits in a Fedora bug -- the RHEL bug is restricted
simply because it originated as a customer request and in any case it merely
depends on this one.  If it really bothers you it can be removed, although I
think that would be a bit silly. :-)

The location of the spec didn't change, but I'll post new copies of the link
for your convenience.

I was working on the changes corresponding to your comments -- your patience is
appreciated.

# is reaaly date and git tag needed?

The code does not correspond with any "official" release.  The date and git tag
are there in an attempt to comply with the packaging guidelines for snapshots.

http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages

# is such a long tag needed?

"use an %{alphatag} beginning with the date in YYYYMMDD format and followed by
up to 16 (ASCII) alphanumeric characters of your choosing" -- is there some
reason that this format/length is unacceptable?  Given that (however unlikely)
the very next git commit could be 599b03bfd1295 I would prefer not to shorten
it.

# is the snaphost pre or post 1.0.0? If pre release should start with 0.
It is post 1.0.0.

# You must add a comment on how you created the tarball.
OK

# why not use [install -D]
OK

# dont compress, rpm do that itself (and might switch to xz)
OK

# use %{_mandir}/man8/ptpd.8*
OK

# URL tag is wrong, that should be web page, not git repo.
There is no proper web page.  But, I changed the URL to point at gitweb
instead.

# Where is the source coming from?
>From the URL I specified, of course.

# Is git.infradead.org a fork of the fork? Please explain.
"Fork of the fork"?  I'm not sure I understand your question.

The original ptpd author/maintainer disappeared somewhat abruptly from the
project.  Intel has a major interest in the project continuing, but a lack of
interest in maintaining it themselves.  So I was recruited to shepherd the
project, and I established the Infradead repository and mailing list for it and
accepted some Intel-authored patches (http://github.com/pohly/ptpd) on top of
the original 1.0.0 release.  Does that answer your question?

Spec URL: http://linville.fedorapeople.org/ptpd.spec
SRPM URL:
http://linville.fedorapeople.org/ptpd-1.0.0-1.20100119git599b03bfd1294.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.