[Bug 530473] Review Request: lessfs - Lessfs is an inline data deduplicating filesystem.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530473

--- Comment #24 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info> 2010-01-27 14:17:13 EST ---
1) You check only src.rpm package, but binary should be checked too:
$ rpmlint *
lessfs.i586: W: spurious-executable-perm /usr/share/doc/lessfs-1.0.0/authors
lessfs.i586: W: spurious-executable-perm /usr/share/doc/lessfs-1.0.0/copying

2,3,4 Ok.

5) Now in package 2 patches. Did you inform upstream developer about your
patches?
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment


Only for note:
mkdir -p %{buildroot}/%{_initddir}
install -m755 etc/lessfs %{buildroot}/%{_initddir}/lessfs

May be replaced by just install with -D:
install -D -m755 etc/lessfs %{buildroot}/%{_initddir}/lessfs
but off course it is not error.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.