[Bug 605373] Review Request: qgis - A user friendly Open Source Geographic Information System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605373

--- Comment #11 from Bruno Wolff III <bruno at wolff.to> 2010-07-03 20:39:04 EDT ---
Kevin thanks for pointing this out to me. I didn't notice it had a new review
request.
I'm happy to give ownership to Volker and stay on as a co-maintainer if it
passes review.

I don't think that gettext applies in this case as the docs for that seemed to
refer to a different setup for handling translations. I don't know enough to be
sure.

I have already noticed a few things.
rpath needs to be stripped from qgis_help as well as qgis.
lupdate-qt4 needs a target. I used "." and that seemed to act reasonably for
the build.
/usr/bin/lupdate-qt4 -no-obsolete . -ts i18n/*.ts

When I checked the bogus executable flag list, I found that
./src/core/composer/qgscomposershape.h and
./src/core/composer/qgscomposershape.cpp no longer were set as executable. You
might want to verify this and remove those two from the chmod list.

The user guide no longer is in the source tar file. Instead an English and
German version are distributed separately under the GDFL. It would be nice to
have those in a -doc subpackage.

The original package put doc files in two different directories and that looked
wrong to me. I hadn't gotten far enough along to check that.

My local test builds have been on F13, but I can do mock f14 builds relatively
easily as I have a local rawhide repo.

I'll take a look at doing builds with the new stuff in rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.