[Bug 547832] Review Request: procServ - A process server with telnet console and log access

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=547832

Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mschwendt at gmail.com

--- Comment #8 from Michael Schwendt <mschwendt at gmail.com> 2010-07-23 09:45:32 EDT ---
Just a brief look at the spec file:


> Summary: A process server with telnet console and log access

Most packages try to be even more concise, e.g.:

  Summary: Process server with telnet console and log access


> %configure --docdir=%{_defaultdocdir}/%{name}-%{version}
> [...]
> %files
> %defattr(-,root,root,-)
> %doc AUTHORS COPYING ChangeLog NEWS README procServ.html procServ.pdf procServ.txt
>

Caution! This is a packaging pitfall.

This definition of --docdir here conflicts with the %doc line. What happens is
that any files installed into the --docdir are killed by %doc, because %doc
creates its target directory from scratch. You would not notice if "make
install" installs additional documentation.

Correct would be:

%configure --docdir=%{_defaultdocdir}/%{name}-%{version}
[...]
%files
%defattr(-,root,root,-)
%{_defaultdocdir}/%{name}-%{version}/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.