[Bug 537983] Review Request: python-visual - 3D Programming

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537983

--- Comment #28 from Thomas Spura <tomspur at fedoraproject.org> 2010-06-02 04:30:52 EDT ---
(In reply to comment #27)
> (In reply to comment #26)
> > > By the way, the build is quite silent, I had to check a generated log file to
> > > check flags and such. I don(t know if it can be considered to be an issue, but
> > > its quite annoying for debugging.    
> > 
> > Yes, it's anoying... Unfortunately, there is not 'the one patch', I could apply
> > to make the buildsystem more verbose. That would change all the time, and
> > that's too much effort atm.
> The patch is indeed not a solution. Anyway, what about this, in %setup ?
>    sed -i 's/2\?>> \?\$(LOGFILE).*//' src/Makefile.in
> It will skip all redirections to the log file in src/Makefile.in

Thanks! I'm not used to such complicated sed commands, mostly just s/foo/bar/g
and that's it...

> 
> > I found a solution for this, but it's a bit hacky ;)
> > 
> > %define _use_internal_dependency_generator 0
> > %define %__find_provides    %{_rpmconfigdir}/find-provides | grep -v
> > cvisualmodule
> > %define %__find_requires    %{_rpmconfigdir}/find-requires | grep -v
> > cvisualmodule
> Maybe you mean:
>    %global _use_internal_dependency_generator 0
>    %global __find_provides    %{_rpmconfigdir}/find-provides | grep -v
> cvisualmodule
>    %global __find_requires    %{_rpmconfigdir}/find-requires | grep -v
> cvisualmodule
> (otherwise I get "error: Macro % has illegal name (%define)", and by the way
> %global is preferred over %define ;))
> I rebuilt your package with these lines, rpmlint is silent now.    

Changed to your version.


Spec URL: http://tomspur.fedorapeople.org/review/python-visual.spec
SRPM URL:
http://tomspur.fedorapeople.org/review/python-visual-5.32-7.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.