[Bug 601036] Review Request: perl-MooseX-LazyRequire - Required attributes which fail only when trying to use them

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601036

--- Comment #1 from Chris Weyl <cweyl at alumni.drew.edu> 2010-06-07 13:11:18 EDT ---
Looks good!

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2234591

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Latest version (0.05) is being packaged.

Source tarballs match upstream (sha1sum):
b1dfa820c6413a3166ffabac62bd854f947c34d9 MooseX-LazyRequire-0.05.tar.gz
b1dfa820c6413a3166ffabac62bd854f947c34d9 MooseX-LazyRequire-0.05.tar.gz.srpm

Final provides / requires are sane:

====> rpmlint perl-MooseX-LazyRequire.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

======> perl-MooseX-LazyRequire-0.05-1.fc14.noarch.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
perl(MooseX::LazyRequire) = 0.05
perl(MooseX::LazyRequire::Meta::Attribute::Trait::LazyRequire) = 0.05
perl-MooseX-LazyRequire = 0.05-1.fc14
====> requires
perl(:MODULE_COMPAT_5.12.0)  
perl(Carp)  
perl(Moose::Exporter)  
perl(Moose::Role)  
perl(MooseX::Types::Moose)  
perl(aliased) >= 0.30
perl(namespace::autoclean)  
====> obsoletes
====> conflicts

======> perl-MooseX-LazyRequire-0.05-1.fc14.src.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
====> requires
perl(ExtUtils::MakeMaker)  
perl(Moose)  
perl(Moose::Exporter)  
perl(Moose::Role)  
perl(MooseX::Types::Moose)  
perl(Test::Exception)  
perl(Test::More) >= 0.88
perl(aliased) >= 0.30
perl(namespace::autoclean)  
====> obsoletes
====> conflicts

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.