[Bug 604653] Review Request: perl-Test-NoTabs - Check the presence of tabs in your project
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jun 21 05:31:07 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=604653
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade at gmail.com
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-06-21 01:31:03 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2261130
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
c76ac17b0988488f5b3a757fc119a8f2c8d6218e Test-NoTabs-1.0.tar.gz.srpm
c76ac17b0988488f5b3a757fc119a8f2c8d6218e Test-NoTabs-1.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=6, Tests=16, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.48 cusr 0.07
csys = 0.58 CPU)
+ Package perl-Test-NoTabs-1.0-3.fc14.noarch =>
Provides: perl(Test::NoTabs) = 1.0
Requires: perl(File::Find) perl(File::Spec) perl(FindBin) perl(Test::Builder)
perl(strict) perl(vars) perl(warnings)
+ Not a GUI application
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list