[Bug 569660] Review Request: perl-File-DirCompare - Perl module to compare two directories using callbacks

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=569660

--- Comment #2 from Chris Weyl <cweyl at alumni.drew.edu> 2010-03-01 21:03:14 EST ---
There's some weirdness about missing files in build.log, but everything else
looks fine, the tests all run (and pass), and the tarball checksums all match
upstream, so... looks like an upstream packaging issue to me.

--------------------------------------
+ /usr/bin/perl Makefile.PL INSTALLDIRS=vendor
Checking if your kit is complete...
Warning: the following files are missing in your kit:
 t/t10/new/aaa
 t/t10/new/ggg
 t/t10/new/jjj
 t/t10/new/xxx
 t/t10/old/aaa
 t/t10/old/ddd
 t/t10/old/ggg
 t/t10/old/uuu
 t/t10/old/xxx
Please inform the author.
--------------------------------------

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2023528

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
f1471fb2eeaf806d62a89e4634146cb61fe9c961 File-DirCompare-0.5.tar.gz
f1471fb2eeaf806d62a89e4634146cb61fe9c961 File-DirCompare-0.5.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-File-DirCompare-0.5-1.fc13.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-File-DirCompare-0.5-1.fc13.noarch.rpm
perl(File::DirCompare) = 0.5
perl-File-DirCompare = 0.5-1.fc13
====> requires for perl-File-DirCompare-0.5-1.fc13.noarch.rpm
perl >= 0:5.005
perl(Carp)  
perl(File::Basename)  
perl(File::Compare)  
perl(File::Glob)  
perl(File::Spec::Functions)  
perl(:MODULE_COMPAT_5.10.1)  
perl(strict)  
perl(vars)  

=====> perl-File-DirCompare-0.5-1.fc13.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-File-DirCompare-0.5-1.fc13.src.rpm
====> requires for perl-File-DirCompare-0.5-1.fc13.src.rpm
perl(ExtUtils::MakeMaker)  
perl(Test::More)  

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.