[Bug 544295] Review Request: upower - Power management service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544295

--- Comment #8 from Terje Røsten <terjeros at phys.ntnu.no> 2010-03-03 10:52:54 EST ---
If the linked spec is the correct one, there are several strange things here:

Requires: dbus-glib >= %{dbus_glib_version}
Requires: glib2 >= %{glib2_version}
Requires: polkit >= %{polkit_version}

The %doc thing is way off:

mkdir -p $RPM_BUILD_ROOT%{_datadir}/doc/%{name}-%{version}
cp README AUTHORS NEWS COPYING HACKING
$RPM_BUILD_ROOT%{_datadir}/doc/%{name}-%{version}

%doc %dir %{_datadir}/doc/%{name}-%{version}
%doc %{_datadir}/doc/%{name}-%{version}/NEWS
%doc %{_datadir}/doc/%{name}-%{version}/COPYINGRequires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig

%doc %{_datadir}/doc/%{name}-%{version}/AUTHORS
%doc %{_datadir}/doc/%{name}-%{version}/HACKING
%doc %{_datadir}/doc/%{name}-%{version}/README

What??

File listing is not good, please be more explicit.

The %define is useless, and should be %global any way.

Is these needed:

Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.