[Bug 565949] Review Request: perl-VOMS-Lite - Perl extension for VOMS Attribute certificate creation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565949

--- Comment #12 from Chris Weyl <cweyl at alumni.drew.edu> 2010-03-07 21:24:34 EST ---
Ok, so. Move the filtering macros before %description (see the below), and
I'll approve :)

Further comments:

The source0 url works; though generally it's best to point right at cpan.org
and let the mirror system hash it out.  The id/M/MI/... location you're using
is spot-on, however.

The filtering macros are being invoked correctly, but generally this is done
before the first %description, to ensure that it has somewhat of a standard
placement, and that it cannot unintentionally become part of a scriptlet
somewhere.  The non-standard filtering looks to be correct, though I'm not
taking too close a look given it's for EPEL and conditionalized away for
Fedora. :)

I see there are a couple extra directories in the tarball that aren't
packaged: examples/ and sbin/.  Why not add them to %doc?

The %description doesn't make a great deal of sense to me.  This doesn't
matter too much if this is intended as just a library package, but I see a
number of executables being installed in /usr/bin... If the primary purpose of
this package is to deliver those execs to end users, you should think about
revising it.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2037155

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
1086f83dfe77332edfa0b08cdd37cd6d8361376c VOMS-Lite-0.09.tar.gz
1086f83dfe77332edfa0b08cdd37cd6d8361376c VOMS-Lite-0.09.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-VOMS-Lite-0.09-3.fc13.noarch.rpm <=====
====> rpmlint
perl-VOMS-Lite.noarch: W: spelling-error %description -l en_US config -> con
fig, con-fig, configure
perl-VOMS-Lite.noarch: W: spelling-error %description -l en_US conf -> con,
cone, cons
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
====> provides for perl-VOMS-Lite-0.09-3.fc13.noarch.rpm
perl(VOMS::Lite) = 0.09
perl-VOMS-Lite = 0.09-3.fc13
perl(VOMS::Lite::AC) = 0.09
perl(VOMS::Lite::ASN1Helper) = 0.09
perl(VOMS::Lite::Attribs::DBHelper) = 0.02
perl(VOMS::Lite::CertKeyHelper) = 0.09
perl(VOMS::Lite::KEY)  
perl(VOMS::Lite::MyProxy) = 0.09
perl(VOMS::Lite::OID)  
perl(VOMS::Lite::PEMHelper) = 0.09
perl(VOMS::Lite::PROXY) = 0.09
perl(VOMS::Lite::REQ) = 0.09
perl(VOMS::Lite::RSAHelper) = 0.09
perl(VOMS::Lite::RSAKey) = 0.09
perl(VOMS::Lite::VOMS) = 0.09
perl(VOMS::Lite::X509) = 0.09
====> requires for perl-VOMS-Lite-0.09-3.fc13.noarch.rpm
perl >= 0:5.004
perl(Crypt::CBC)  
perl(Crypt::DES_EDE3)  
perl(DBI)  
perl(Digest::MD2)  
perl(Digest::MD5)  
perl(Digest::SHA1)  
perl(Exporter)  
perl(File::Copy)  
perl(HTTP::Daemon::SSL)  
perl(HTTP::Request)  
perl(HTTP::Response)  
perl(HTTP::Status)  
perl(IO::Socket)  
perl(IO::Socket::SSL)  
perl(LWP::UserAgent)  
perl(Math::BigInt)  
perl(Math::BigInt::GMP)  
perl(MIME::Base64)  
perl(:MODULE_COMPAT_5.10.1)  
perl(Regexp::Common)  
perl(strict)  
perl(Sys::Hostname)  
perl(Term::ReadKey)  
perl(Time::Local)  
perl(vars)  
perl(VOMS::Lite)  
perl(VOMS::Lite::AC)  
perl(VOMS::Lite::ASN1Helper)  
perl(VOMS::Lite::CertKeyHelper)  
perl(VOMS::Lite::KEY)  
perl(VOMS::Lite::MyProxy)  
perl(VOMS::Lite::PEMHelper)  
perl(VOMS::Lite::PROXY)  
perl(VOMS::Lite::REQ)  
perl(VOMS::Lite::RSAHelper)  
perl(VOMS::Lite::RSAKey)  
perl(VOMS::Lite::VOMS)  
perl(VOMS::Lite::X509)  
perl(warnings)  
/usr/bin/perl  

=====> perl-VOMS-Lite-0.09-3.fc13.src.rpm <=====
====> rpmlint
perl-VOMS-Lite.src: W: spelling-error %description -l en_US config -> con fig,
con-fig, configure
perl-VOMS-Lite.src: W: spelling-error %description -l en_US conf -> con, cone,
cons
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
====> provides for perl-VOMS-Lite-0.09-3.fc13.src.rpm
====> requires for perl-VOMS-Lite-0.09-3.fc13.src.rpm
perl(Crypt::DES_EDE3)  
perl(Digest::MD2)  
perl(Digest::SHA1)  
perl(ExtUtils::MakeMaker)  
perl(IO::Socket::SSL)  
perl(Math::BigInt::GMP)  
perl(Regexp::Common)  
perl(Term::ReadKey)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.