[Bug 573929] Review Request: perl-Compress-Raw-Zlib - Low-Level Interface to zlib compression library

Tue Mar 16 16:51:29 UTC 2010

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=573929

--- Comment #2 from Mark Chappell <tremble at tremble.org.uk> 2010-03-16 12:51:26 EDT ---
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [!] Package meets the Packaging Guidelines including the Perl specific items
   * Looks like a bundled ZLib
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2056653
 [x] Rpmlint output:
vampire:~ $ rpmlint perl-Compress-Raw-Zlib-*
perl-Compress-Raw-Zlib.src: E: specfile-error sh: line 1: fg: no job control
perl-Compress-Raw-Zlib.src: E: specfile-error sh: line 1: fg: no job control
3 packages and 0 specfiles checked; 2 errors, 0 warnings.
*These are fine*
 [x] Package is not relocatable.
 [x] Buildroot is correct
     Buildroot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license. 
     License type: GPL+ or Artistic
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
5b637dbb36955b13db261f049fe529d9  Compress-Raw-Zlib-2.024.tar.gz
5b637dbb36955b13db261f049fe529d9  Compress-Raw-Zlib-2.024.tar.gz.1
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [!] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [x] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2056654
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: fedora-rawhide-x86_64 and fedora-rawhide-i686
 [-] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [] The placement of pkgconfig(.pc) files is correct.
 [] File based requires are sane.
 [x] %check is present and the tests pass
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/000prereq.t ...... ok
t/01version.t ...... ok
t/02zlib.t ......... ok
t/07bufsize.t ...... ok
t/09limitoutput.t .. ok
t/18lvalue.t ....... ok
t/99pod.t .......... skipped: Test::Pod 1.00 required for testing POD
All tests successful.
Files=7, Tests=699,  3 wallclock secs ( 0.11 usr  0.06 sys +  2.14 cusr  0.16
csys =  2.47 CPU)
Result: PASS

===

Couple of  issues,

* Looks like it's using the bundled zlib, see the README for details on how to
avoid this http://cpansearch.perl.org/src/PMQS/Compress-Raw-Zlib-2.024/README

* You're using $RPM_BUILD_ROOT and $RPM_OPT_FLAGS where the rest of the time
you're using %{} macros this feels wrong, but is probably okay...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.