[Bug 589162] Review Request: stress - A tool to put given subsystems under a specified load

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589162

Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |terjeros at phys.ntnu.no

--- Comment #1 from Terje Røsten <terjeros at phys.ntnu.no> 2010-05-06 04:57:21 EDT ---
Some initial comments:

 - many files in the tarball has execute bit set, giving: 

stress.x86_64: W: spurious-executable-perm /usr/share/doc/stress-1.0.4/README
stress.x86_64: W: spurious-executable-perm /usr/share/doc/stress-1.0.4/TODO
stress.x86_64: W: spurious-executable-perm
/usr/share/doc/stress-1.0.4/doc/stress.texi
stress.x86_64: W: spurious-executable-perm /usr/share/doc/stress-1.0.4/AUTHORS
stress.x86_64: W: spurious-executable-perm /usr/share/doc/stress-1.0.4/INSTALL
stress.x86_64: W: spurious-executable-perm
/usr/share/doc/stress-1.0.4/doc/Makefile.am
stress.x86_64: W: spurious-executable-perm
/usr/share/doc/stress-1.0.4/doc/mdate-sh
stress.x86_64: W: spurious-executable-perm /usr/share/doc/stress-1.0.4/NEWS
stress-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/stress-1.0.4/src/stress.c

Please fix that by chmod in %prep.

- You include the whole doc/ dir in %doc, however the only useful file (already
  not included) is stress.html.

- License: headers in stress.c has GPLv2+, while COPYING has GPLv3. 
  Adding to the mess the web page states GPLv2. Current sitaution
  means license tag is GPLv2+, however you should contact upstream
  about this issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.