[Bug 576685] Review Request: pekwm - A small and flexible window manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576685

--- Comment #10 from Germán Racca <gracca at gmail.com> 2010-05-09 22:44:31 EDT ---
(In reply to comment #9)

Hello Christoph. Please find the updated files here:

Spec URL: http://sites.google.com/site/gracca/pekwm.spec
SRPM URL: http://sites.google.com/site/gracca/pekwm-0.1.12-3.fc12.src.rpm

> Sorry it took so long.

No problem :-)

> I have no problems sponsoring you, you have done well here and in the other
> reviews. However there are still some problems with the package:

Nice to hear this! Thanks!

> drwxr-xr-x  /usr/share/doc/pekwm-0.1.12/contrib
> -rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/Makefile
> -rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/Makefile.am
> -rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/Makefile.in
> drwxr-xr-x  /usr/share/doc/pekwm-0.1.12/contrib/lobo
> -rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/Makefile
> -rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/Makefile.am
> -rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/Makefile.in
> -rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/README
> -rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/check.png
> -rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/pekwm_autoprop.pl
> -rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/pekwm_menu_config.pl
> -rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/pekwm_menu_config.pl.vars
> -rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/uncheck.png
> 
> As you can see the Makefiles end up in the package. Your options:
> 1. Remove them in %install
> 2. Install the the files individually and not the whole contrib folder. Then
> you could also nuke the "lobo" subfolder which is useless as long as it is the
> only one.    

I did the following here. I removed the makefiles from the contrib folder:

find contrib/Makefile* -type f | xargs rm -rf || true
find contrib/lobo/Makefile* -type f | xargs rm -rf || true

and then I rearranged the contents of the contrib folder:

mv contrib/lobo/* contrib/
rm -rf contrib/lobo

Is this made in the right way? Please tell me if I'm doing something wrong or
something that is not allowed to.

Here are the outputs of rpmlint:

$ rpmlint SPECS/pekwm.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint SRPMS/pekwm-0.1.12-3.fc12.src.rpm 
pekwm.src: W: spelling-error %description -l en_US aewm -> Newman, anew, aerie
pekwm.src: W: spelling-error %description -l en_US pwm -> wpm, pm, pom
pekwm.src: W: spelling-error %description -l en_US fluxbox -> flux box,
flux-box, fluxing
pekwm.src: W: spelling-error %description -l en_US autoproperties -> auto
properties, auto-properties, properties
pekwm.src: W: spelling-error %description -l en_US xinerama -> Cinerama,
mineral, cameraman
pekwm.src: W: spelling-error %description -l en_US keygrabber -> key grabber,
key-grabber, grabber
pekwm.src: W: spelling-error %description -l en_US keychains -> key chains,
key-chains, enchains
1 packages and 0 specfiles checked; 0 errors, 7 warnings.

$ rpmlint RPMS/i686/pekwm-0.1.12-3.fc12.i686.rpm 
pekwm.i686: W: spelling-error %description -l en_US aewm -> Newman, anew, aerie
pekwm.i686: W: spelling-error %description -l en_US pwm -> wpm, pm, pom
pekwm.i686: W: spelling-error %description -l en_US fluxbox -> flux box,
flux-box, fluxing
pekwm.i686: W: spelling-error %description -l en_US xinerama -> Cinerama,
mineral, cameraman
pekwm.i686: W: spelling-error %description -l en_US keygrabber -> key grabber,
key-grabber, grabber
pekwm.i686: W: spelling-error %description -l en_US keychains -> key chains,
key-chains, enchains
pekwm.i686: W: unstripped-binary-or-object /usr/bin/pekwm
pekwm.i686: E: executable-marked-as-config-file /etc/pekwm/start
1 packages and 0 specfiles checked; 1 errors, 7 warnings.

Cheers,
German.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.