[Bug 593841] Review Request: wicd - Wireless and wired network connection manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593841

--- Comment #10 from leigh scott <leigh123linux at googlemail.com> 2010-05-21 20:35:16 EDT ---
There is a problem here, it can't own this directory as it belongs to
hicolor-icon-theme (the others listed are due to bad packaging)



%dir %{_datadir}/icons/hicolor


[leigh at localhost Desktop]$ rpm -qf /usr/share/icons/hicolor
hicolor-icon-theme-0.12-1.fc13.noarch
krb5-auth-dialog-0.15-1.fc13.x86_64
fedora-logos-13.0.2-1.fc13.noarch
setroubleshoot-2.2.83-1.fc13.x86_64
[leigh at localhost Desktop]$ 


Change it from

%files gtk
%defattr(-,root,root,-)
%dir %{_datadir}/wicd/gtk
%dir %{_datadir}/pixmaps/wicd
%dir %{_datadir}/icons/hicolor
%config(noreplace) %{_sysconfdir}/xdg/autostart/wicd-tray.desktop
%{_datadir}/wicd/gtk/*
%{_datadir}/pixmaps/wicd/*
%{_datadir}/pixmaps/wicd-gtk.xpm
%{_bindir}/wicd-gtk
%{_datadir}/icons/hicolor



to

%files gtk
%defattr(-,root,root,-)
%dir %{_datadir}/wicd/gtk
%dir %{_datadir}/pixmaps/wicd
%config(noreplace) %{_sysconfdir}/xdg/autostart/wicd-tray.desktop
%{_datadir}/wicd/gtk/*
%{_datadir}/pixmaps/wicd/*
%{_datadir}/pixmaps/wicd-gtk.xpm
%{_bindir}/wicd-gtk
%{_datadir}/icons/hicolor/*/apps/wicd-gtk.png
%{_datadir}/icons/hicolor/scalable/apps/wicd-gtk.svg



There are still some rpmlint errors that need correcting ( mainly shebangs )

wicd.src: W: spelling-error %description -l en_US cli -> cl, clii, clip
wicd.src: W: spelling-error %description -l en_US frontend -> fronted, front
end, front-end
wicd.x86_64: E: explicit-lib-dependency dbus-glib
wicd.x86_64: W: spelling-error %description -l en_US frontend -> fronted, front
end, front-end
wicd.x86_64: E: no-binary
wicd.x86_64: E: executable-marked-as-config-file
/etc/acpi/suspend.d/50-wicd-suspend.sh
wicd.x86_64: E: non-executable-script /usr/share/wicd/cli/wicd-cli.py 0644L
/usr/bin/python
wicd.x86_64: E: non-executable-script /usr/share/wicd/daemon/wicd-daemon.py
0644L /usr/bin/env
wicd.x86_64: E: non-executable-script /usr/share/wicd/backends/be-external.py
0644L /usr/bin/env
wicd.x86_64: E: non-executable-script /usr/share/wicd/backends/be-ioctl.py
0644L /usr/bin/env
wicd.x86_64: E: non-executable-script
/usr/lib/python2.6/site-packages/wicd/logfile.py 0644L /usr/bin/python
wicd.x86_64: E: wrong-script-end-of-line-encoding
/usr/lib/python2.6/site-packages/wicd/logfile.py
wicd.x86_64: E: executable-marked-as-config-file
/etc/acpi/resume.d/80-wicd-connect.sh
wicd.x86_64: W: log-files-without-logrotate /var/log/wicd
wicd-curses.x86_64: E: non-executable-script
/usr/share/wicd/curses/curses_misc.py 0644L /usr/bin/env
wicd-curses.x86_64: E: non-executable-script
/usr/share/wicd/curses/netentry_curses.py 0644L /usr/bin/env
wicd-curses.x86_64: E: non-executable-script
/usr/share/wicd/curses/prefs_curses.py 0644L /usr/bin/env
wicd-gtk.x86_64: W: no-documentation
wicd-gtk.x86_64: E: non-executable-script /usr/share/wicd/gtk/gui.py 0644L
/usr/bin/python
wicd-gtk.x86_64: E: non-executable-script /usr/share/wicd/gtk/prefs.py 0644L
/usr/bin/python
wicd-gtk.x86_64: E: non-executable-script /usr/share/wicd/gtk/wicd-client.py
0644L /usr/bin/env
4 packages and 0 specfiles checked; 16 errors, 5 warnings.




As for the networkmanager issue, would this work?



%post
if [ $1 -eq 1 ]; then
    /sbin/chkconfig --add wicd
    /sbin/chkconfig --level 2345 wicd on
    /sbin/chkconfig --level 2345 NetworkManager off
    /sbin/service NetworkManager stop >/dev/null 2>&1
fi

%preun
if [ $1 -eq 0 ]; then
    /sbin/service wicd stop >/dev/null 2>&1
    /sbin/chkconfig --del wicd
    /sbin/chkconfig --level 2345 NetworkManager on
    /sbin/service NetworkManager start >/dev/null 2>&1
fi

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.