[Bug 478613] Review Request: ledger - A powerful command-line double-entry accounting system

bugzilla at redhat.com bugzilla at redhat.com
Tue May 25 16:57:44 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478613

Jim Radford <radford at blackbean.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(radford at blackbean |
                   |.org)                       |

--- Comment #7 from Jim Radford <radford at blackbean.org> 2010-05-25 12:57:40 EDT ---
> http://fedoraproject.org/wiki/Packaging:UnownedDirectories
> MUST: Packages must not own files or directories already owned by other
packages

It is common for this rule to be broken for the very reasons I outlined.  See
for example the rule on MIME files.

  https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo

Notice that like bash_completion, you just drop a file in the directory.  If
you have shared-mime-info, bash-completion or in this case emacs installed then
things just work and if you don't they work as well.  Win-win.

The reason humans do reviews is so they can make exceptions to well meaning but
not always applicable rules.  If these prominent examples are not enough to
convince you, I'm sure I can find more...

See:

  clisp
  puppet
  monotone
  ...

Then again there are lots of packages that have a separate emacs packages.  I
still hold that this is a stupid practice.  I want things to just work and
given the limits of rpm/yum, the best way in this case to just include the
emacs mode in the main package.

As for the directory ownership issue, I'm ambivalent.  Some packages (like
puppet) grab the common directory and some like the users of bash-completion
and shared-mime-info don't.  Given that the latter uses are explicit policy, I
lean toward that, but both have merits.

> I'd find it hard to go ahead with this review. I suggest contacting the fedora-packaging list for a clarification, or I can step back and you can try convincing another maintainer that dangling links are the best way out of this.

No problem. Thanks for your time.  I'll consider bringing it up on the list if
no one else steps up.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list