[Bug 575466] Review Request: gtk-aurora-engine - Aurora GTK+ theme engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=575466

--- Comment #17 from Hans de Goede <hdegoede at redhat.com> 2010-11-05 07:14:29 EDT ---
Full review done, results below:

Good:
- rpmlint checks return:
  3 packages and 0 specfiles checked; 0 errors, 0 warnings.
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+) OK, text in %doc
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Needs work:
-%install
 Is missing a
 rm -rf %{buildroot}
 As the first line, this is not strictly needed anymore, but if you're going
 to not do it also remove %clean and the setting of BuildRoot
-You're not preserving timestamps when installing the files from
 Aurora.tar.bz2 (replace "cp -r" with "cp -pr")
-Needs a "Requires: gtk2", because 1: it is useless without gtk2,
 2: for %{_libdir}/gtk-2.0/2.10.0/engines dir ownership
-You should mail upstream about adding copyright headers to there files if not
 done already (not a blocker)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.