[Bug 592504] Review Request: nodebrain - a declarative rule-based language for state and event monitoring

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592504

--- Comment #5 from Jason Tibbitts <tibbs at math.uh.edu> 2010-11-19 14:16:52 EST ---
Current comaintainers for graphviz are alexlan and tremble; I don't think
you're in there.

Some random comments:

0.8.3 seems to be available.

If you can do a parallel make (using %{?_smp_mflags}), please do so; otherwise
please indicate in a comment why it does not work.  Who likes to wait when we
all have multicore machines these days?

Please use the recommended scriptlets from
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo.

rpmlint complains many times about dangling symlinks:
  nodebrain-devel.x86_64: W: dangling-relative-symlink
   /usr/lib64/nb/nb_peer.so nb_peer.so.0.0.1
which is a bit odd.  I think the issue is that rpmlint doesn't understand
things going in a subdirectory of _libdir, but then that begs the question of
just what the stuff in /usr/lib(64)/nb really is.  If that stuff is just
plugins that are dlopen'ed, there's probably no need for them to have devel
symlinks.  lib/nbmodule.c:nbModuleLoad does imply that there are dlopen'ed
plugins.

  nodebrain.x86_64: E: zero-length /usr/share/doc/nodebrain-0.8.0/ChangeLog
Any idea why the ChangeLog is empty?  Is there any point in shipping it if it's
empty?

  nodebrain.x86_64: W: file-not-utf8 /usr/share/info/nbTutorial.info.gz
It looks like there's some kind of weird microsoft-encoded single-quite stuff
in nbTutorial.info:
  illustrate this, let<92>s first write a simple Perl script named
Should probably be replaced with a proper single quote.  There may be more
stuff in there; I didn't search through the entire 4000 line document.

  nodebrain.x86_64: W: no-manual-page-for-binary nb-0.8.0
This is OK; the nb link has a manpage.

  nodebrain-debuginfo.x86_64: E: debuginfo-without-sources
This implies that either the executables are being stripped, or the program
isn't compiled with the proper flags.  It looks like it's the latter; for
whatever reason, the configure script is ignoring the OS-supplied compiler
flags.  This must be fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.