[Bug 641471] Review Request: python26-mod_wsgi - A WSGI interface for Python web applications in Apache

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641471

Carl Thompson <fedora at red-dragon.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at red-dragon.com

--- Comment #3 from Carl Thompson <fedora at red-dragon.com> 2010-10-10 14:51:52 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
See below - Meets Packaging Guidelines.
See below - License
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
6172bb2bbabcd0c25867c2bc06f99dbb  mod_wsgi-3.3.tar.gz
6172bb2bbabcd0c25867c2bc06f99dbb  mod_wsgi-3.3.tar.gz

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
See below - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
OK - No rpmlint output. 
 - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

rpmlint python26-mod_wsgi-3.3-1.fc13.src.rpm 
python26-mod_wsgi.src: W: spelling-error %description -l en_US wsgi -> swig,
wigs
python26-mod_wsgi.src: W: spelling-error %description -l en_US runtime -> run
time, run-time, runtish
python26-mod_wsgi.src: W: invalid-url Source0:
http://modwsgi.googlecode.com/files/mod_wsgi-3.3.tar.gz HTTP Error 404: Not
Found
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

rpmlint -i python26-mod_wsgi-3.3-1.fc13.src.rpm 
python26-mod_wsgi.src: W: spelling-error %description -l en_US wsgi -> swig,
wigs
The value of this tag appears to be misspelled. Please double-check.

python26-mod_wsgi.src: W: spelling-error %description -l en_US runtime -> run
time, run-time, runtish
The value of this tag appears to be misspelled. Please double-check.

python26-mod_wsgi.src: W: invalid-url Source0:
http://modwsgi.googlecode.com/files/mod_wsgi-3.3.tar.gz HTTP Error 404: Not
Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

1 packages and 0 specfiles checked; 0 errors, 3 warnings.

The url is valid even if rpmlint says it isn't, confirmed manually

I like the approach of not putting it in Conflicts but using the conf file to
ensure that both modules
are not loaded into apache simultaneously

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.