[Bug 640627] Review Request: rubygem-factory_girl - Framework and DSL for defining and using model instance factories

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=640627

--- Comment #4 from Michal Fojtik <mfojtik at redhat.com> 2010-10-14 07:30:15 EDT ---
(In reply to comment #3)
> Everything looks good save the patch for the Rakefile, the proper way to do it
> would be something like this in the %prep section:
> 
> %setup -q -c -T
> 
> mkdir -p ./%{gemdir}
> gem install --local --install-dir ./%{gemdir} \
>             --force --rdoc %{SOURCE0}
> 
> pushd ./%{geminstdir}
> %patch0
> popd
> 
> 
> 
> and then in the %install section
> 
> %install
> rm -rf %{buildroot}
> mkdir -p %{buildroot}%{gemdir}
> cp -a .%{gemdir}/* %{buildroot}%{gemdir}
> 
> 
> See rubygem-activerecord as an example of how to do this

Thanks for noticing that, it looks definitely better right now.
Fixed. 

> http://pkgs.fedoraproject.org/gitweb/?p=rubygem-activerecord.git;a=blob;f=rubygem-activerecord.spec
> 
> 
> Other than that, everything else looks great. rpmlint is fine, it builds on
> koji, and I did a surface functionality test.

==================== 1.3.2-2 ====================

* Thu Oct 14 2010 Michal Fojtik <mfojtik at redhat.com> - 1.3.2-3
- Replaced path with path macro

Spec URL: http://mifo.sk/RPMS/rubygem-factory_girl.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-factory_girl-1.3.2-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.