[Bug 642856] Review Request: drupal-flexifilter - Allows non-admins to create their own, configurable custom filters

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 15 13:19:22 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642856

Sven Lankes <sven at lank.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(sven at lank.es)     |

--- Comment #4 from Sven Lankes <sven at lank.es> 2010-10-15 09:19:21 EDT ---
(In reply to comment #3)

> PASSED although you may want to file a ticket upstream to get the spelling
> corrected.

I can adjust the spelling to what rpmlint wants - no problem. Although my
dictionary does list 'extendable' as a preferctly valid word.

> Paul pointed out that your %define at the top shoudl be changed to
> %{_datadir}/drupal6 and the name of the module should be changed to
> drupal6-flexifilter.

Nope. I'm not sure what the guidelines say but I don't want to put a package 
into EPEL that is not in Fedora (when it could be) yet so this review has
to be for Fedora where drupal is correct. I would then create another review
for drupal6-flexinode (which should be quick as it's mostly the same).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list