[Bug 647926] Review Request: xsettingsd - Provides settings to X11 clients via the XSETTINGS specification

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647926

--- Comment #11 from Peter Lemenkov <lemenkov at gmail.com> 2010-10-30 15:13:11 EDT ---
REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is NOT silent

sulaco ~/rpmbuild/SPECS: rpmlint ~/Desktop/xsettingsd-*
xsettingsd.i686: W: spurious-executable-perm
/usr/share/man/man1/xsettingsd.1.gz
xsettingsd.i686: W: spurious-executable-perm
/usr/share/man/man1/dump_xsettings.1.gz
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
sulaco ~/rpmbuild/SPECS:

These messages were fixed already (just re-download spec-file).

+ The package is named according to the  Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license (BSD).
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.

sulaco ~/rpmbuild/SOURCES: sha256sum derat-xsettingsd-7804894.tar.gz*
fd7a6e6a8cc9c45ef230aba25b5167da2a4b61e229af34f68045eac0036cea84 
derat-xsettingsd-7804894.tar.gz
fd7a6e6a8cc9c45ef230aba25b5167da2a4b61e229af34f68045eac0036cea84 
derat-xsettingsd-7804894.tar.gz.1
sulaco ~/rpmbuild/SOURCES:

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files in some of the dynamic linker's default paths.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.