[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 7 19:57:51 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589867

--- Comment #18 from Matthias Runge <mrunge at matthias-runge.de> 2010-09-07 15:57:51 EDT ---
Thanks for the review.

Some of those errors resp. warnings are not so easy to fix. I decided to set
the permissions more fedora-like. INSTALL-file says, logcheck-user should own
the config-files. I cannot see a reason for this, or why root may not own them,
esp. why those config files may not me read by other users. Information hiding
does not work in most cases. 

mrunge at sofja noarch]$ rpmlint logcheck-1.3.13-1.fc14.noarch.rpm
logcheck.noarch: W: non-standard-uid /var/lib/logcheck logcheck
logcheck.noarch: W: non-standard-gid /var/lib/logcheck logcheck
logcheck.noarch: E: non-standard-dir-perm /var/lib/logcheck 0700L
logcheck.noarch: W: manual-page-warning /usr/share/man/man8/logcheck.8.gz 1:
warning: macro `\"' not defined
logcheck.noarch: W: non-standard-uid /var/lock/logcheck logcheck
logcheck.noarch: W: non-standard-gid /var/lock/logcheck logcheck
logcheck.noarch: E: non-standard-dir-perm /var/lock/logcheck 0700L

Adding a new user and group makes such messages. logcheck should own
/var/lib/logcheck and /var/lock/logcheck. Those permissions are sane to me.

Fixed files:
SPEC: http://www.matthias-runge.de/fedora/logcheck.spec
SRPM: http://www.matthias-runge.de/fedora/logcheck-1.3.13-1.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list