[Bug 631190] Review Request: libnxt - An utility for flashing LEGO Mindstorms NXT firmware

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=631190

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de> 2010-09-12 15:01:36 EDT ---
Hi Damian,

here are some initial comments on your package:

- Remove the article "An" and the final dot from the Summary. It's just a 
  convention to keep the summary concise. 

- add short comments to the spec file telling what the patches do

- drop "Requires: libusb" as rpm automatically adds it as a dependency

- You must ensure that the binaries are built with CCFLAGS='%{optflags}' (the
  cross-compiled flash binary is an exception). Unfortunately, scons doesn't 
  seem to accept variable definitions given as command-line arguments. Thus, 
  you have to patch them into SConstruct.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.