[Bug 618042] Review Request: kwebkitpart - A KPart based on QtWebKit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=618042

Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Rex Dieter <rdieter at math.unl.edu> 2010-09-14 19:25:11 EDT ---
naming : ok

scriptlets : ok

license : ok

sources:
$ md5sum *.bz2
017b56eae5462617bf5fded092280e1f  127960-kwebkitpart-0.9.6.tar.bz2

rpmlint clean (as noted)

builds in mock

installs/upgrades cleanly, Obsoletes properly.

functions ok in casual usage.


Small nitpicks that can be fixed post review:
1. -devel: 
change 
Requires: kdelibs4-devel >= 4.4.0
to just
Requires: kdelibs4-devel
(the versioning is handled already via the runtime dependencies)

2.  since this is multilib'd should change
%{?_kde4_version:Requires: kdelibs4>= %{_kde4_version}}
to
%{?_kde4_version:Requires: kdelibs4%{?_isa} >= %{_kde4_version}}


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.