[Bug 634515] Review Request: python-zope-i18n - Zope Internationalization Support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=634515

--- Comment #2 from Toshio Ernie Kuratomi <a.badger at gmail.com> 2010-09-16 19:56:06 EDT ---
Good:
* Package follows naming guidelines
* Spec's name matches package
* Spec is readable
* Source matches upstream
* Not a shared library
* No bundled libraries
* Not relocatable
* Includes all directories that it creates.
* Permissions set properly
* Consistent use of macros
* Code not content
* Not a GUI application
* Does not own files or directories from another package
* All filenames UTF8
* Builds in koji

Needswork:
* License should be ZPLv2.1 and UCD because of the Unicode license on part of
the data
* UCD license text is in src/zope/i18n/locales/data/license.html which should
be pulled into %doc
* Locales: language files aren't being marked as belonging to a specific
language
* Locales: under /usr/lib rather than %{_datadir} -- FHS wants architecture
independent data file in %{_datadir}

I'll attach some sample patches for these issues.

Cosmetic:

Notes:
* I've had to read up quickly on what configure.zcml files are.  If I read it
  correctly, they're configuration of underlying pieces of framework by the
  current code.  The files are not meant for system admins/end-users to edit to
  configure anything.  Is that correct?

* rpmlint:
python-zope-i18n.src: W: no-cleaning-of-buildroot %install
python-zope-i18n.src: W: no-cleaning-of-buildroot %clean
python-zope-i18n.src: W: no-buildroot-tag
python-zope-i18n.src: W: no-%clean-section

These are fine unless building on EPEL-5 or F12.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.