[Bug 767838] Review Request: libclastfm - Unofficial C-API for the Last.fm web service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=767838

--- Comment #3 from Christoph Wickert <cwickert at fedoraproject.org> 2011-12-16 08:47:44 EST ---
Thanks for the review.

(In reply to comment #2)
>
> Juste two suggestions, before approving this package:
> - since autoconf is already required by libtool, you could remove autoconf from
> the BuildRequires

Ok, do you want me to change this now or can I do this after you approved the
package?

> - unless you intend to maintain libclastfm for EPEL 5, you should remove the
> %clean section in you .spec file, as well as all the BuildRoot cleans and the
> BuildRoot tag:
>    http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
>    http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

The guidelines don't say I should remove it bug I could. I like keeping these
things around for backwards compatibility.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.