[Bug 533167] Review Request: emacs-ecb - Emacs Code Browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=533167

Ruediger Landmann <r.landmann at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.landmann at redhat.com
               Flag|                            |needinfo?(kklic at redhat.com)

--- Comment #13 from Ruediger Landmann <r.landmann at redhat.com> 2011-02-03 00:23:46 EST ---
Thanks Karel!

Package builds fine locally and on Koji, but rpmlint is noisy:

$ rpmlint SPECS/emacs-ecb.spec 
SPECS/emacs-ecb.spec: W: invalid-url Source0: ecb-cvs20101021.tar.xz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

* Expected. Spec includes instructions to obtain source from upstream CVS.

$ rpmlint SRPMS/emacs-ecb-2.40-0.3.cvs20101021.fc14.src.rpm
emacs-ecb.src: W: spelling-error %description -l en_US xemacs -> XEmacs
emacs-ecb.src: W: invalid-url Source0: ecb-cvs20101021.tar.xz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

* "xemacs" is fine here; it's in a package name.

$ rpmlint RPMS/noarch/emacs-ecb-2.40-0.3.cvs20101021.fc14.noarch.rpm
emacs-ecb.noarch: W: unexpanded-macro dependency emacs(bin) >= %{emacs_version}
%{emacs_version}
emacs-ecb.noarch: W: spelling-error %description -l en_US xemacs -> XEmacs
emacs-ecb.noarch: W: incoherent-version-in-changelog 2.40.1-0.3.cvs20101021
['2.40-0.3.cvs20101021.fc14', '2.40-0.3.cvs20101021']
emacs-ecb.noarch: W: file-not-utf8 /usr/share/info/ecb.info-2.gz
emacs-ecb.noarch: W: file-not-utf8 /usr/share/info/ecb.info-1.gz
emacs-ecb.noarch: W: file-not-utf8 /usr/share/info/ecb.info-3.gz
emacs-ecb.noarch: W: file-not-utf8 /usr/share/doc/emacs-ecb-2.40/NEWS
1 packages and 0 specfiles checked; 0 errors, 7 warnings.

* Typo in macro; should be %{_emacs_version}
* Version: should be 2.40.1 per the included Release Notes
* Please change encodings to UTF-8. Refer to:
https://fedoraproject.org/wiki/PackageMaintainers/PackagingTricks#Convert_encoding_to_UTF-8

$ rpmlint RPMS/noarch/emacs-ecb-el-2.40-0.3.cvs20101021.fc14.noarch.rpm
emacs-ecb-el.noarch: W: spelling-error Summary(en_US) Elisp -> Elis, Lisp,
Elise
emacs-ecb-el.noarch: W: spelling-error %description -l en_US elisp -> lisp, e
lisp, Elise
emacs-ecb-el.noarch: W: no-documentation

* OK

Please fix the above issues and build a new SRPM.

Cheers
Rudi

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.