[Bug 675050] Review Request: cloudfs - Cloud Filesystem

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675050

--- Comment #6 from Ralf Corsepius <rc040203 at freenet.de> 2011-02-04 10:43:35 EST ---
(In reply to comment #5)
> (In reply to comment #4)
> > /usr/include/glusterfs/iatt.h
> > contains
> > #include "uuid.h"
> > 
> > This means this file want to include /usr/include/uuid.h
> 
> To be more precise, it means that it wants to include uuid.h from the first
> place in its include path where it exists,
Correct, ...

=> a package using -I/usr/include/glusterfs will not get the real
/usr/include/uuid.h (unless resorting to dirty tricks such as 
-I/usr/include/glusterfs -I/usr/include or #include_next <uuid.h>).

> where said include path by default
> has /usr/include and some gcc-version-specific directories unless -nostdinc is
> used.  It's not uncommon at all for programs to include their own headers
> without full qualification, and the use of quotes instead of angle brackets is
> commonly taken as a hint that they're doing so.
Well, ... I can't prevent people from stopping to stick with bad habits and
them being addicted by questionable designs ;)

> I completely agree.  Nonetheless, they are the upstream for that package and
> that's the way their headers are structured.  I guess the most relevant issue
> is whether this questionable practice in the glusterfs package should be a
> blocker for cloudfs.
To be able to answer this, I'll have to recheck your rpm 
(Not today, it's 17:00 local time and I've got go AFK).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.