[Bug 623606] Review Request: gxneur - GTK front-end for X Neural Switcher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=623606

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review-              |fedora-review+

--- Comment #14 from Martin Gieseking <martin.gieseking at uos.de> 2011-02-06 16:00:22 EST ---
(In reply to comment #13)
> Martin, thank you very much for the review! Can I make response review for you?

You're welcome, and thanks for the offer. However, I currently don't have any
packages in the queue waiting for a reviewer.


> (In reply to comment #12)
> build fix and is not so important. But previous svn build (it in changelog of
> xneur if you want see) was to fix error what I ask upstream author. So, full
> version dependency should be used to pull correct version!

If gxneur actually does require the corresponding xneur (the complete package
and not just the library it was linked against), this should be mentioned
somewhere in the docs. Also, the build system should check whether the proper
version is present. Maybe you can ask upstream to add this. 
As requested by the guidelines, you should also add a comment above Requires:
xneur = %{version} why this explicit dependency is necessary.
http://fedoraproject.org/wiki/PackagingDrafts/ExplicitRequires

----------------
Package APPROVED
----------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.