[Bug 650282] Review Request: rubygem-rspec-expectations - Rspec-2 expectations (should and matchers)
bugzilla at redhat.com
bugzilla at redhat.com
Wed Feb 23 12:26:23 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=650282
Vít Ondruch <vondruch at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review+
--- Comment #3 from Vít Ondruch <vondruch at redhat.com> 2011-02-23 07:26:23 EST ---
* Unnecessary prep section
- The "gem install" could be moved into install section. This is not MUST,
however it would simplify the spec file a bit.
* Test suite
- Some specs are not executed (there are 4 specs missing). The test suite
should be executed by following command preferably:
ruby -rubygems -Ilib/ -S rspec spec
- What about executing Cucumber test suite? But there is probably missing
packaged Aruba gem :/
* Koji:
- Builds fine on Koji
http://koji.fedoraproject.org/koji/taskinfo?taskID=2859873
Neither one of the above is showstopper, so the package is APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list