[Bug 652778] Review Request: kanotf font - OpenType Kannada fonts

bugzilla at redhat.com bugzilla at redhat.com
Sun Feb 27 07:25:09 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652778

Ankur Sinha <sanjay.ankur at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sanjay.ankur at gmail.com
         AssignedTo|nobody at fedoraproject.org    |sanjay.ankur at gmail.com
               Flag|                            |fedora-review?

--- Comment #1 from Ankur Sinha <sanjay.ankur at gmail.com> 2011-02-27 02:25:08 EST ---
Hi!

Looks good. One glitch though, I don't see the version being provided by
upstream anywhere. In such cases it's preferred to use the time stamp.


# Do not trust font metadata versionning unless you've checked upstream does
# update versions on file changes. When in doubt use the timestamp of the most
# recent file as version. “1.0” versions especially are suspicious.

Please check this up. I'll do a complete review later today. 

Thanks,
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list