[Bug 664912] Review Request: perl-HTML-TreeBuilder-LibXML - HTML::TreeBuilder and XPath compatible interface with libxml

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=664912

--- Comment #1 from Petr Pisar <ppisar at redhat.com> 2011-01-17 11:48:22 EST ---
Source file is original. Ok.
Summary verified from lib/HTML/TreeBuilder/LibXML.pm. Ok.
License verified from lib/HTML/TreeBuilder/LibXML.pm. Ok.
Description verified from lib/HTML/TreeBuilder/LibXML.pm. Ok.

All tests pass. Ok.

$ rpmlint perl-HTML-TreeBuilder-LibXML.spec
../SRPMS/perl-HTML-TreeBuilder-LibXML-0.12-1.fc14.src.rpm
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.12-1.fc14.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint Ok.

$ rpm -q -lv -p
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.12-1.fc14.noarch.rpm 
drwxr-xr-x    2 root    root                        0 led 17 17:31
/usr/share/doc/perl-HTML-TreeBuilder-LibXML-0.12
-rw-r--r--    1 root    root                     1685 zář 21 01:42
/usr/share/doc/perl-HTML-TreeBuilder-LibXML-0.12/Changes
-rw-r--r--    1 root    root                      576 bře 24  2009
/usr/share/doc/perl-HTML-TreeBuilder-LibXML-0.12/README
-rw-r--r--    1 root    root                     2470 led 17 17:31
/usr/share/man/man3/HTML::TreeBuilder::LibXML.3pm.gz
-rw-r--r--    1 root    root                     1993 led 17 17:31
/usr/share/man/man3/HTML::TreeBuilder::LibXML::Node.3pm.gz
drwxr-xr-x    2 root    root                        0 led 17 17:31
/usr/share/perl5/HTML
drwxr-xr-x    2 root    root                        0 led 17 17:31
/usr/share/perl5/HTML/TreeBuilder
drwxr-xr-x    2 root    root                        0 led 17 17:31
/usr/share/perl5/HTML/TreeBuilder/LibXML
-rw-r--r--    1 root    root                     3778 zář 21 01:41
/usr/share/perl5/HTML/TreeBuilder/LibXML.pm
-rw-r--r--    1 root    root                     4788 pro 25  2009
/usr/share/perl5/HTML/TreeBuilder/LibXML/Node.pm

File permissions and layout Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.12-1.fc14.noarch.rpm | sort |
uniq -c
      1 perl(base)  
      1 perl(Carp)  
      1 perl(:MODULE_COMPAT_5.12.2)  
      1 perl(strict)  
      1 perl(warnings)  
      1 perl(XML::LibXML)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rpmlib(VersionedDependencies) <= 3.0.3-1
FIX: Require perl(HTML::TreeBuilder::XPath) >= 0.11
(lib/HTML/TreeBuilder/LibXML.pm:73:, META.yml)
FIX: Version perl(XML::LibXML) to >= 1.7 (META.yml)

$ rpm -q --provides -p
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.12-1.fc14.noarch.rpm | sort |
uniq -c
      1 perl(HTML::TreeBuilder::LibXML::Node)  
      1 perl(HTML::TreeBuilder::LibXML) = 0.12
      1 perl-HTML-TreeBuilder-LibXML = 0.12-1.fc14
Binary provides Ok.

$ resolvedeps-f15
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.12-1.fc14.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2726221). Ok.

Otherwise package is in line with Fedora and perl packaging guidelines.


Please correct all `FIX' prefixed issues and provide new spec file.
Resolution: Package NOT approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.