[Bug 658420] Review Request: zorba - General purpose XQuery processor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=658420

--- Comment #4 from Martin Gieseking <martin.gieseking at uos.de> 2011-01-25 15:55:00 EST ---
Thanks for your thorough review, Jussi. I'll fix the issues in the next days. 


(In reply to comment #2)
> "Installation directory
> All JAR files MUST go into %{_javadir} or a Java-version specific directory
> %{_javadir}-* as appropriate[1]. If the number of provided JAR files exceeds
> two, you MUST place them into a sub-directory named %{name}."
> 
> Is there any reason you're not complying to this in the -java package?

I have to look into this again. It might be related to JNI stuff but I can't
find the corresponding .so file at the moment. It's probably a leftover from a
previous packaging attempt.


> You should be able to disable RPATH altogether within CMake. See
> http://www.cmake.org/Wiki/CMake_RPATH_handling

Yes, I did try that but it didn't work. The rpaths were still present. Maybe
something went wrong. Will try it again.


(In reply to comment #3)
> You *do* realize, that you won't be able to do version updates in any branch,
> since the soname will break every time...?

Yes, I do and I'm not happy with it. I'll try to link this library statically
as it seems to be a private one not intended for external usage.


> It's a bit funny that ASCII and XML files are placed in %{_libdir}/zorba/.
> There are a few ELF files, too, though..

Right, but as far as I see, there's no good alternative location to put both
text and library files into.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.