[Bug 662258] Review Request: ghc-pcre-light - A regex library for Perl 5 compatible regular expressions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662258

--- Comment #4 from Ben Boeckel <mathstuf at gmail.com> 2011-01-26 19:05:16 EST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > 1) These errors from rpmlint should be fixed if possible:
> > > 
> > > ghc-pcre-light-prof.x86_64: E: devel-dependency ghc-pcre-light-devel
> > > ghc-pcre-light-prof.x86_64: W: devel-file-in-non-devel-package
> > > /usr/lib64/ghc-6.12.3/pcre-light-0.4/libHSpcre-light-0.4_p.a
> > 
> > Standard Haskell packaging things. These files are used when profiling the code
> > which implies that the -devel package exist.
> 
> Shouldn't the libHSpcre-light-0.4_p.a appear in the devel package rather than
> in the main package?

The _p is the profiling library. The -devel library does not have it.

> > > 2) There shouldn't be common_summary, common_description, and ghc_pkg_c_deps
> > > macros since these are only used once.  The ghc_pkg_deps line should be removed
> > > completely because the macro is undefined.
> > 
> > These are also standard Haskell packaging things. I think the %{common_*}
> > macros are used in the %{?ghc_lib_package} line which is where the -prof and
> > -devel subpackages are defined.
> 
> I don't see any reference to this on the Haskell packaging guidelines page:
> 
> http://fedoraproject.org/wiki/Packaging/Haskell

If you look at the spec files generated from cabal2spec, they're used there.
Maybe the wiki needs some updating.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.