[Bug 672953] Review Request: python26-jsonschema - JSON Schema is a specification for defining the structure of JSON data

bugzilla at redhat.com bugzilla at redhat.com
Thu Jan 27 14:23:17 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672953

--- Comment #2 from Jeffrey Ness <jeffrey.ness at rackspace.com> 2011-01-27 09:23:16 EST ---
Hello BJ,

Thanks for reviewing this package.

Spec URL: http://flip-edesign.com/source/junk/python26-jsonschema.spec
SRPM URL:
http://flip-edesign.com/source/junk/python26-jsonschema-0.2a-2.el5.src.rpm

Below is the rpmlint for SPEC and RPM:

---
$ rpmlint SPECS/python26-jsonschema.spec sh: /usr/bin/python2.6: No such file
or directorysh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
sh: /usr/bin/python2.6: No such file or directory
SPECS/python26-jsonschema.spec: W: invalid-url Source0:
http://jsonschema.googlecode.com/files/jsonschema-0.2a.tar.gz HTTP Error 404:
Not Found
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpmlint
/var/lib/mock/epel-5-i386-jeffrey.ness/result/python26-jsonschema-0.2a-2.el5.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
---

This package built successfully in mock using epel-5-i386
---

I have corrected each check you mentioned above, however I had to leave the
explicit attr on the .py files to resolves rpmlint errors:

$ rpmlint
/var/lib/mock/epel-5-i386-jeffrey.ness/result/python26-jsonschema-0.2a-2.el5.noarch.rpm 
python26-jsonschema.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/jsonschema/__init__.py 0644L /usr/bin/env
python26-jsonschema.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/jsonschema/validator.py 0644L /usr/bin/env
1 packages and 0 specfiles checked; 2 errors, 0 warnings.
---

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list