[Bug 701079] Review Request: wmSun - Rise/Set time of Sun in a dockapp
bugzilla at redhat.com
bugzilla at redhat.com
Fri Jul 1 17:52:52 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=701079
--- Comment #7 from Mario Blättermann <mariobl at freenet.de> 2011-07-01 13:52:51 EDT ---
(In reply to comment #6)
> - You can maybe change the spelling (dockapp -> dock app).
>
It is the usual spelling for Windowmaker related applets:
http://en.wikipedia.org/wiki/Dockapp
> - You can also get rid of the rm -rf $RPM_BUILD_ROOT in the install section. It
> is not needed any more.
>
Done.
> - Debuginfo is still empty. This is because the fedora optflags are not being
> honoured in the build:
...
> make COPTS='%{optflags}' %{?_smp_mflags}
>
Done.
Updated package:
Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/wmSun.spec
SRPM URL:
http://mariobl.fedorapeople.org/Review/SRPMS/wmSun-1.03-4.fc15.src.rpm
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3174781
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list