[Bug 714408] Review Request: tlomt-league-gothic-fonts - a sans serif gothic typeface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714408

--- Comment #3 from Kevin Fenzi <kevin at scrye.com> 2011-07-02 11:56:39 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (OFL)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
72b228695f1ad8ac0e3824a1e7edb313  league-gothic.zip
72b228695f1ad8ac0e3824a1e7edb313  ../SOURCES/league-gothic.zip
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues: 

1. Not a blocker, but you might add to the description. Reading just what you
have
makes it sound like this is a public domain font from 1903, but in fact the
second
paragraph upstream says: "We decided to make our own version, and contribute 
it to the Open Source Type Movement. It’s free, not only in price, but in
freedom"
So, perhaps a note that this is a version of that font? 

2. Might ask upstream if they could include a copy of the OFL in their zip
file?
(Not a blocker, but nice to have). 

3. rpmlint says: 

tlomt-league-gothic-fonts.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Which can be ignored. 

Fix up the description and I think we are good to go...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.