[Bug 693126] Review Request: openvas-administrator - Administrator Module for the Open Vulnerability Assessment System (OpenVAS)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693126

Siem Korteweg <siem at xs4all.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |siem at xs4all.nl

--- Comment #2 from Siem Korteweg <siem at xs4all.nl> 2011-07-14 16:18:01 EDT ---
Some remarks, as this is not a formal review.

- the source rpm is for FC14, not FC15

- rpmbuild failed:
  extend the Buildrequires with gcc and xmltoman

- you do not need a %clean script:
  refer to http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

- systemd is required for init-scripts for Fedora 15+:
  refer to
http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_in_addition_to_systemd_unit_files
  this also affects the current Requires

- sqlite-devel is not required for building
  after removing this rpm and removing its Buildrequires from the spec file,
the rpmbuild succeeded and all files in the new rpm have the same size as
before

- why do you require file /usr/bin/xsltproc and not the rpm libxslt it is
contained in?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.