[Bug 720998] Review Request: OpenNL - A library for solving sparse linear systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=720998

--- Comment #7 from Richard Shaw <hobbes1069 at gmail.com> 2011-07-15 10:29:49 EDT ---
Ack! I've been spoiled by "make install" :)

I've fixed it and I'm doing a mock build now to make sure. Due to the symbolic
links the "cp" command needed "-a" not "-p". It was copying the target of the
symlink (the real library) instead of copying the symlink itself.

Ok, done with the mock build and unfortunately cmake does not create the
library with the correct permissions (0775 instead of 0755). There may be a way
to fix that during the build but the only reference I could find to PERMISSIONS
was during "install" and of course we are manually installing.

Also, since we can't copy them over all at once I had to use some 'find' mojo. 

I know in some ways this seems like more work than what you were doing (and it
may well be) but it's generally better not to rely on macros and hard coded
paths whenever practical. Although in this particular case you were pretty sure
this was the last version it's best to try and keep things automatic as
possible. I'm pretty sure if there was a new patch release you could just
upload the new source, change the version in the spec file, and rebuild. 

Double Ack! They don't include the patch level in the version for the source
archive file name... Oh well. I think we're close enough :)

Here's the spec file with the fixes for the library install:

http://hobbes1069.fedorapeople.org/OpenNL.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.