[Bug 226383] Merge Review: rwall

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226383

Peter Schiffer <pschiffe at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |hhorak at redhat.com,
                   |                            |pschiffe at redhat.com
         AssignedTo|nobody at fedoraproject.org    |pschiffe at redhat.com
               Flag|                            |fedora-review?

--- Comment #1 from Peter Schiffer <pschiffe at redhat.com> 2011-07-28 11:39:15 EDT ---
Checked srpm:
$ sha256sum rwall-0.17-31.fc16.src.rpm
e576f3c65b9e55d349b75c818bd0be80fdeeaa3c9c75230cca366f2c46009d63
rwall-0.17-31.fc16.src.rpm

N/A source files match upstream - I was not able to download upstream tarball.

YES package meets naming and versioning guidelines.
YES specfile is properly named, is cleanly written and uses macros
consistently.
YES dist tag is present.
INFO clean section and buildroot present - clean section 
is not necessary any more and buildroot is ignored - they should be removed.
YES license field matches the actual license.
YES license is open source-compatible.
YES License text included in package.
N/A latest version is being packaged - upstream looks dead.
N/A BuildRequires are proper.
YES compiler flags are appropriate.
YES package builds in mock (Rawhide/x86_64).
YES debuginfo package looks complete.

NO rpmlint is silent.

$ rpmlint rwall.spec 
rwall.spec:26: E: prereq-use /sbin/chkconfig /etc/init.d
 - PreReq has to be replaced by Requires.
rwall.spec:77: E: use-of-RPM_SOURCE_DIR
 - $RPM_SOURCE_DIR has to be replaced by $RPM_BUILD_ROOT.
rwall.spec:216: W: macro-in-%changelog %postun
 - macro in changelog has to be escaped, e.g.: %%postun
rwall.spec:216: W: macro-in-%changelog %preun
 - same as above.
rwall.spec:249: W: macro-in-%changelog %attr
 - same as above.
rwall.spec: E: specfile-error warning: line 26: prereq is deprecated: Prereq:
/sbin/chkconfig /etc/init.d
0 packages and 1 specfiles checked; 3 errors, 3 warnings.

$ rpmlint rwall-0.17-31.fc16.src.rpm 
rwall.src: W: summary-ended-with-dot C Client for sending messages to a host's
logged in users.
 - easy to fix.
rwall.src: W: no-url-tag
 - is there any live upstream ULR?
rwall.src: W: strange-permission rwalld.init 0755L
rwall.src:26: E: prereq-use /sbin/chkconfig /etc/init.d
rwall.src:77: E: use-of-RPM_SOURCE_DIR
rwall.src:216: W: macro-in-%changelog %postun
rwall.src:216: W: macro-in-%changelog %preun
rwall.src:249: W: macro-in-%changelog %attr
rwall.src: E: specfile-error warning: line 26: prereq is deprecated: Prereq:
/sbin/chkconfig /etc/init.d
1 packages and 0 specfiles checked; 3 errors, 6 warnings.

$ rpmlint rwall-0.17-31.fc16.x86_64.rpm 
rwall.x86_64: W: summary-ended-with-dot C Client for sending messages to a
host's logged in users.
rwall.x86_64: W: no-url-tag
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint rwall-server-0.17-31.fc16.x86_64.rpm 
rwall-server.x86_64: W: summary-ended-with-dot C Server for sending messages to
a host's logged in users.
rwall-server.x86_64: W: no-url-tag
rwall-server.x86_64: W: conffile-without-noreplace-flag /etc/rc.d/init.d/rwalld
rwall-server.x86_64: E: executable-marked-as-config-file
/etc/rc.d/init.d/rwalld
 - binary cannot be marked as config file even in /etc dir
rwall-server.x86_64: W: incoherent-init-script-name rwalld ('rwall-server',
'rwall-serverd')
 - this can be ignored
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

$ rpmlint rwall-debuginfo-0.17-31.fc16.x86_64.rpm 
rwall-debuginfo.x86_64: W: no-url-tag
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

YES final provides and requires look sane.
N/A %check is present and all tests pass.
YES no shared libraries are added to the regular linker search paths.
YES owns the directories it creates.
YES doesn't own any directories it shouldn't.
YES no duplicates in %files.
YES scriptlets must be sane.
YES code, not content.
N/A large documentation files must go in a -doc subpackage.
YES %docs are not necessary for the proper functioning of the package.
YES no headers.
YES no pkgconfig files.
YES no libtool .la droppings.
YES not a GUI app.

Additional comments:
 * URL in source tag is not working. It has to be commented out with note
and added like this - Source: netkit-rwall-%{version}.tar.gz
 * %build section could be simplified by removing perl

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.